On Sat, 2014-03-22 at 23:25 -0300, João Henrique Ferreira de Freitas
wrote:
> Hi Tom,
>
> I am working to enhance the patches with your comments.
>
> Em 21-03-2014 12:54, Tom Zanussi escreveu:
> > In any case, I think the connection between a command-line param and the
> > line in the .wks file should be explicit, but I'm not sure about the
> > best way do do that, maybe something like:
> >
> > wic create ... --rootfs-dir rootfs1=/some/rootfs/dir --rootfs-dir
> > rootfs2=/some/other/rootfs/dir
> >
> > part / --source rootfs --rootfs-dir="rootfs1" --ondisk sda --fstype=ext3
> > --label primary --align 1024
> >
> > part /standby --source rootfs --rootfs-dir="rootfs2" \
> > --ondisk sda --fstype=ext3 --label secondary --align 1024
> >
> > In the above case, 'rootfs1' and 'rootfs2' provide the connection (and
> > could be named anything, they're just strings).
>
> What about to use '--label' or mountpoint as connection?
>
I suppose using --label would be ok, though I don't really like to
overload things like this in general, and it forces the partitions to
have labels.
> wic create ... --rootfs-dir primary=/some/rootfs/dir --rootfs-dir
> secondary=/some/other/rootfs/dir
>
>
>
> > So I guess that's what make sense to me, but I'd be happy to hear other
> > ideas.
> >
> > In any case, at minimum I think that you should change the syntax from
> > --rootfs=<special rootfs directory> to --rootfs-dir=<special rootfs
> > directory>, in keeping with current syntax.
>
> Agree.
>
> >
> > Another thing missing is displaying the extra partitions in the output
> > e.g.
>
> Agree.
>
> > I created an image with the added /standby, and it worked but I
> > didn't see it mentioned in the output, which it should be:
> > [trz@empanada build]$ wic create directdisk-multi -e core-image-minimal
> > Checking basic build environment...
> > Done.
> >
> > Creating image(s)...
> >
> > Info: The new image(s) can be found here:
> > /var/tmp/wic/build/directdisk-multi-201403211050-sda.direct
> >
> > The following build artifacts were used to create the image(s):
> > ROOTFS_DIR:
> > /home/trz/yocto/master-cur/build/tmp/work/crownbay-poky-linux/core-image-minimal/1.0-r0/rootfs
> > BOOTIMG_DIR:
> > /home/trz/yocto/master-cur/build/tmp/sysroots/crownbay/usr/share
> > KERNEL_DIR:
> > /home/trz/yocto/master-cur/build/tmp/sysroots/crownbay/usr/src/kernel
> > NATIVE_SYSROOT:
> > /home/trz/yocto/master-cur/build/tmp/sysroots/x86_64-linux
> >
> >
> > The image(s) were created using OE kickstart file:
> >
> > /home/trz/yocto/master-cur/scripts/lib/image/canned-wks/directdisk-multi.wks
> >
> > Thanks,
>
> Why BOOTIMG_DIR is pointing to
> /home/trz/yocto/master-cur/build/tmp/sysroots/crownbay/usr/share ? It
> could be /var/tmp/wic/build/hdd/boot?
>
The listing is supposed to tell the user where it found the artifacts as
a sanity check, e.g. what the variables or -e expanded to and thus where
the artifacts came from. /var/tmp/wic/build/hdd/boot doesn't tell you
that.
> And what do you thing about this output ?
>
> Checking basic build environment...
> Done.
>
> Creating image(s)...
>
> Info: The new image(s) can be found here:
> /var/tmp/wic/build/directdisk-multi-rootfs-201403222319-sda.direct
>
> The following build artifacts were used to create the image(s):
> /boot /var/tmp/wic/build/hdd/boot
> /
> /srv/build/yocto/master/tmp/work/genericx86-poky-linux/core-image-minimal/1.0-r0/rootfs
> /standby
> /srv/build/yocto/master/tmp/work/genericx86-poky-linux/core-image-minimal-dev/1.0-r0/rootfs
> /root_test
> /srv/build/yocto/master/tmp/work/genericx86-poky-linux/core-image-minimal-dev/1.0-r0/rootfs
> KERNEL_DIR:
> /srv/build/yocto/master/tmp/sysroots/genericx86/usr/src/kernel
> NATIVE_SYSROOT: /srv/build/yocto/master/tmp/sysroots/x86_64-linux
>
>
That seems kind of unreadable to me. Why not just add another
ROOTFS_DIR line for anything beyond the default rootfs e.g.
ROOTFS_DIR:
/home/trz/yocto/master-cur/build/tmp/work/crownbay-poky-linux/core-image-minimal/1.0-r0/rootfs
ROOTFS_DIR["secondary"]:
/home/trz/yocto/master-cur/build/tmp/work/crownbay-poky-linux/core-image-minimal-dev/1.0-r0/rootfs
BOOTIMG_DIR:
/home/trz/yocto/master-cur/build/tmp/sysroots/crownbay/usr/share
KERNEL_DIR:
/home/trz/yocto/master-cur/build/tmp/sysroots/crownbay/usr/src/kernel
NATIVE_SYSROOT:
/home/trz/yocto/master-cur/build/tmp/sysroots/x86_64-linux
Tom
> The image(s) were created using OE kickstart file:
> /home/joaohf/jhf/opensource/poky/scripts/lib/image/canned-wks/directdisk-multi-rootfs.wks
>
> Thanks.
>
> --
> João Henrique Ferreira de Freitas - joaohf_at_gmail.com
> Campinas-SP-Brasil
>
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
