On Tue, Dec 3, 2013 at 7:38 PM, Bruce Ashfield <bruce.ashfi...@windriver.com > wrote:
> On 12/3/2013, 5:40 PM, Richard Purdie wrote: > >> On Tue, 2013-12-03 at 11:40 -0700, Chris Larson wrote: >> >>> On Wed, Nov 27, 2013 at 11:07 AM, Christopher Larson >>> <kerg...@gmail.com> wrote: >>> The following changes since commit >>> f991d2d60b74f5ebd990f77aecd3324b1a4533e9: >>> >>> libpng: set reasonable SUMMARY (2013-11-27 11:51:08 +0000) >>> >>> are available in the git repository at: >>> >>> https://github.com/kergoth/oe-core.git random-fixes >>> https://github.com/kergoth/oe-core/tree/random-fixes >>> >>> Christopher Larson (7): >>> update-rc.d: process symlinks recursively >>> perf: remove /usr/local/include from default makefile >>> includes >>> pulseaudio: fix RDEPENDS traversal for consolekit >>> >>> Were there issues with these, or was it just that further testing was >>> necessary? I noticed this series was partially applied. >>> >> >> On the most part just being cautious for M1. >> >> The perf one does worry me as we keep going around in circles on it >> where we change one thing, it breaks something else, we fix that, >> something else breaks, we fix that and we end up back where we started. >> The commit history and/or the mailing list should have details about >> what happened there. CC'ing Bruce since I know he has opinions on the >> perf fix. Bruce, did we get a fix for that upstream in the end? >> > > My favourite topic. I'm working on the upstream fix, which was that we > shouldn't be using CFLAGS and LDFLAGS to pass build values into perf, > but instead use EXTRA_CLFAGS (which exists) and EXTRA_LDFLAGS (Which > doesn't exist yet, and that's the patch I have queued). > > Looking at Chris' posted patch, I can't actually tell what it was fixing, > since INCLUDES isn't directly used by the perf Makefiles and on > a really quick check, I can't see what CONFIG_INCLUDES is set to either. > > I'm sure I'm just being dense (long day) and I'm missing something, so > I can't map the short log's intent to what the patch is actually doing. > > The patch won't undo anything that we are working to fix/change > upstream, but since something is whizzing over my head, I can't be sure > about side effects. *shrug*, it’s possible it was to fix warnings only with older kernels, as we use our own BSPs in some cases. I’m not opposed to you dropping that patch, it was only a warning fix for us anyway :) -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
_______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
