On 12/02/2013 05:08 PM, Nathan Rossi wrote:
-----Original Message-----
From: Saul Wold [mailto:s...@linux.intel.com]
Sent: Tuesday, December 03, 2013 6:00 AM
To: Nathan Rossi; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] attr: attr_2.4.47 release tarball missing
configure.ac

On 11/25/2013 12:18 AM, Nathan Rossi wrote:
The release tarball of attr 2.4.47 is missing the configure.ac file.
This prevents the autotools bbclass from being able to regenerate the
configure script which leads to other side affects. (e.g. using
outdated config.sub)

This patch adds the configure.ac file via a patch.
(obtained via the source repository at the v2.4.47 tag)

See the mailing list thread for additional information:
http://lists.nongnu.org/archive/html/acl-devel/2013-05/msg00024.html

Signed-off-by: Nathan Rossi <nathan.ro...@xilinx.com>
---

On an additional note, acl 2.2.52 is also affected by this issue.
However it does not affect oe-core as acl has yet to be updated to this
version and currently sits on the older 2.2.51 version.

---
   meta/recipes-support/attr/attr_2.4.47.bb           |    3 +
   .../attr/files/attr-Missing-configure.ac.patch     |   62
++++++++++++++++++++
   2 files changed, 65 insertions(+)
   create mode 100644 meta/recipes-support/attr/files/attr-Missing-
configure.ac.patch

diff --git a/meta/recipes-support/attr/attr_2.4.47.bb b/meta/recipes-
support/attr/attr_2.4.47.bb
index a1f2e05..ad40c9b 100644
--- a/meta/recipes-support/attr/attr_2.4.47.bb
+++ b/meta/recipes-support/attr/attr_2.4.47.bb
@@ -1,5 +1,8 @@
   require attr.inc

+# configure.ac was missing from the release tarball. This should be
fixed in
+# future releases of attr, remove this when updating the recipe.
+SRC_URI_append += "file://attr-Missing-configure.ac.patch"

   SRC_URI[md5sum] = "84f58dec00b60f2dc8fd1c9709291cc7"
   SRC_URI[sha256sum] =
"25772f653ac5b2e3ceeb89df50e4688891e21f723c460636548971652af0a859"
diff --git a/meta/recipes-support/attr/files/attr-Missing-
configure.ac.patch b/meta/recipes-support/attr/files/attr-Missing-
configure.ac.patch
new file mode 100644
index 0000000..5887ed5
--- /dev/null
+++ b/meta/recipes-support/attr/files/attr-Missing-configure.ac.patch
@@ -0,0 +1,62 @@
+Subject: [PATCH] attr: Missing configure.ac
+
+Upstream-Status: Backport [Upstream released tarball missing this file]

You need a Signed-off-by: tag in this patch also


Hi Saul,

This patch has already been pushed onto the master branch. 
http://git.openembedded.org/openembedded-core/commit/?id=b28f12a272a9e2f0c3084a58b91605acb05f58f8

Yes, I noticed this after I sent the message!

Would you like me to submit a follow up patch which adds just the signed-off-by 
line? Or would you prefer a V2 of this patch with the additional change?

Please send a patch to add the signed-off-by line to the patch, we try to keep track of who added the patches so we have the history.

Thanks
        Sau!


Regards,
Nathan




_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to