On Thu, 2013-10-31 at 01:54 -0500, blloyd wrote:
> gdb includes a script to make generating core files trivial. Add a package
> to allow inclusion of this script in images. GDB also requires symbols that
> are usually stripped from the threads library to properly generate a core
> dump. Therefore, ensure when gdb is installed the necessary debug file is
> also present so gdb is fully functional.
>
> Signed-off-by: blloyd <bll...@familyhonor.net>
> ---
> meta/recipes-devtools/gdb/gdb-common.inc | 12 +++++++-----
> meta/recipes-devtools/gdb/gdb.inc | 9 ++++++++-
> 2 files changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/meta/recipes-devtools/gdb/gdb-common.inc
> b/meta/recipes-devtools/gdb/gdb-common.inc
> index 6954954..02eef85 100644
> --- a/meta/recipes-devtools/gdb/gdb-common.inc
> +++ b/meta/recipes-devtools/gdb/gdb-common.inc
> @@ -61,8 +61,10 @@ do_install_append() {
> rm -rf ${D}${datadir}/locale
> }
>
> -RRECOMMENDS_gdb_append_linux = " glibc-thread-db "
> -RRECOMMENDS_gdb_append_linux-gnueabi = " glibc-thread-db "
> -RRECOMMENDS_gdbserver_append_linux = " glibc-thread-db "
> -RRECOMMENDS_gdbserver_append_linux-gnueabi = " glibc-thread-db "
> -
> +# Unfortunately, for gdb multi-threading to function reliably it must have
> the eglibc debug symbols
> +# which are a part of the eglibc-dev package. So we have added a dependency
> on that here.
> +RRECOMMENDS_gdb_append_linux = " glibc-thread-db eglibc-dev "
> +RRECOMMENDS_gdb_append_linux-gnueabi = " glibc-thread-db eglibc-dev "
> +RRECOMMENDS_gdbserver_append_linux = " glibc-thread-db eglibc-dev "
> +RRECOMMENDS_gdbserver_append_linux-gnueabi = " glibc-thread-db eglibc-dev "
> +RDEPENDS_gcore_append = " gdb "
Aren't they part of the -dbg package, not -dev?
You also need to put "gdb: " at the start of the commit message summary
as per the commit message guidelines. It may be worth splitting this
change into two commits too.
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
