Hi Colin, On Sun, 2013-07-07 at 17:55 -0400, Colin Walters wrote: > On Fri, 2013-07-05 at 12:27 +0300, Stefan Stanacar wrote: > > > + actualcmd = "ssh -o UserKnownHostsFile=/dev/null -o > > StrictHostKeyChecking=no -l root %s '%s'" % (self.host, cmd) > > This is going to fail if cmd contains a single quote. Personally, I > *always* pass around subprocess arguments as an array. Anything else is > going to lead to quoting problems. > > >
You're right, I just sent a patch that drops that and doesn't use shlex anymore. Thanks, Stefan _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
