On 07/02/2013 06:25 PM, Burton, Ross wrote:
> On 1 July 2013 14:57, Laurentiu Palcu <laurentiu.pa...@intel.com> wrote:
>> +do_install() {
>> + # Only install file if it has a contents
>> + if [ -s ${S}/pointercal.xinput ]; then
>> + install -d ${D}${sysconfdir}/
>> + install -m 0644 ${S}/pointercal.xinput ${D}${sysconfdir}/
>> + fi
>> +}
>
> The file always has content because the file in the main recipe has a
> comment in. Personally I think not installing a useless file is the
> right thing to do, so we should change the default pointercal.xinput
> to be empty.
Then why install it at all if it's empty? I believe a zero sized file in
/etc it's even worse.
>
> Relatedly, interestingly Weston has a different approach and attaches
> the calibration to the device using udev properties, which means
> systems where touch devices can be hotplugged actually work. I'm
> incredibly tempted to extend xinput-calibrator to write out udev
> fragments and make Xi respect them if they exist...
Ross, you requested (according to the description in bugzilla:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=4416#c0 ) to just move
xinput-calibrator to oe-core from meta-oe. Technically, the first
patchset did just that. It would have been easier for me, from the
planning point of view at least, if I had known in advance the
additional changes you needed for this package. I admit I don't know how
all packages in oe-core or meta-oe should or shouldn't work... I'm
working on improving that though. ;)
So, perhaps it would be better for all of us if you documented all these
additional change requests in bugzilla. Would that be OK with you?
>
>> +++ b/meta/recipes-graphics/xinput-calibrator/xinput-calibrator_git.bb
>> +inherit autotools systemd
>
> systemd?
Will be removed
>
>> +RPROVIDES_${PN} += "${PN}-systemd"
>> +RREPLACES_${PN} += "${PN}-systemd"
>> +RCONFLICTS_${PN} += "${PN}-systemd"
>
> It doesn't anymore, so these can be dropped.
Ack
Laurentiu
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
