On 16 May 2013 00:02, Paul Barker <p...@paulbarker.me.uk> wrote: > On 15 May 2013 21:33, Richard Purdie <richard.pur...@linuxfoundation.org> > wrote: > >> >> (e.g. when I include >> meta-raspberrypi, it changes the psplash logo, regardless of whether I'm >> building for the pi). >> >> In many ways the bbappend is too easy and encourages anti-social >> behaviour. I would recommend bouncing meta-rpi as being non yocto >> project compatible due to the psplash issue if it were to apply which it >> has not. >> > > I noticed the psplash logo when building a qemu image with > meta-raspberrypi included, will look into fixing it so it only goes > into MACHINE="raspberrypi" builds. Copying in yocto@ and Andrei as > this is raspberrypi related. >
I've just sent a patch to the yocto@ list to fix this but it's brought up two things: 1) In openembedded-core/meta/classes/image.bbclass SPLASH is set with '?='. I'm overriding this with '=' in meta-raspberrypi/conf/machine/raspberrypi.conf which means it can't be overridden further in local.conf. Is this worth changing to '??=' in image.bbclass, '?=' in the machine conf so that it can be overridden with '=' in local.conf? Is my understanding of the overrides correct here? 2) If you look at the patch I've basically added the raspberrypi logo as an extra psplash image and overridden SPLASH in the machine conf to make this the default for raspberrypi. Is this the intended approach for customising psplash images? There's a lot of interesting logic in the psplash recipe and it took me a while to figure out. If I've got it right it may be worth adding some documentation comments to explain this method. If I've got it wrong could someone correct me. Both of these (assignment change and adding documentation) would be patches to openembedded-core. Thanks. -- Paul Barker Email: p...@paulbarker.me.uk http://www.paulbarker.me.uk _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
