Hi Andrei,
On Wednesday 03 April 2013 18:30:47 Andrei Dinu wrote:
> Removed the package files parsing routine from the
> packageinfo.bbclass file and added it to the
> package.bbclass file.
>
> Signed-off-by: Andrei Dinu <andrei.adrianx.d...@intel.com>
> ---
> meta/classes/package.bbclass | 10 ++++++++++
> meta/classes/packageinfo.bbclass | 20 --------------------
> 2 files changed, 10 insertions(+), 20 deletions(-)
>
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 3479947..cafe339 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -1130,6 +1130,13 @@ python emit_pkgdata() {
> workdir = d.getVar('WORKDIR', True)
>
> for pkg in packages.split():
> + items = {}
> + for files_list in pkgfiles[pkg]:
> + if
> files_list.split(files_list.split('/')[len(files_list.split('/'))-1])[0][:-
> 1] not in items: +
> items[files_list.split(files_list.split('/')[len(files_list.split('/'))-1])
> [0][:-1]] = [] +
> items[files_list.split(files_list.split('/')[len(files_list.split('/'))-1])
> [0][:-1]].append(files_list.split('/')[len(files_list.split('/'))-1]) +
> else:
> +
> items[files_list.split(files_list.split('/')[len(files_list.split('/'))-1])
> [0][:-1]].append(files_list.split('/')[len(files_list.split('/'))-1])
> subdata_file = pkgdatadir + "/runtime/%s" % pkg
I'd recommend the use of os.path.basename() here; additionally rather than
repeating the same call several times (possibly expensive within a loop),
assign the return value to a variable and then use that instead.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
