On Thu, 2026-07-16 at 13:02 +0300, Leon Anavi via lists.openembedded.org wrote: > Hi Paul, Joshua, Philipp, > > Philipp, Joshua thank you for the code review and for the insights > regarding weston and weston-init. In the long term, discussing > modifications to weston and weston-init probably makes sense. > However, for the moment, I think my single-line change to add pam to > the defaults is simple and makes sense, especially considering that > this fix is also suitable for cherry-picking to release Wrynose.
I have to disagree, whilst it is a single line change, it does have significant implications as it changes the distro feature configuration and may require the user to take specific actions if they don't want or need pam in their system. Changing such a thing in an LTS release series now is not a change we can undertake lightly. So yes, it might backport easily but that doesn't mean it means the policy criteria. I'm afraid we need to work out and resolve this issue properly, not rushing a fix. I will push back harder on taking this if merging will make it an instant backport request! I should also highlight that as soon as I did merge this patch, everyone would move on and do something else leaving the other questions unresolved. That is another reason I don't think I should merge something which I don't think is the right/complete fix. > Paul, following your initial code review, could you please have a > look at the third iteration of this patch? I would appreciate your > feedback on whether any additional modifications on my side are > necessary to get it merged in the upstream. > > Please note that my modification through DISTRO_FEATURES_DEFAULTS > targets the nodistro and the yocto-check-layer use case. I consider > this change to be safe because in my opinion Poky or custom > distributions are expected to define an explicit DISTRO_FEATURES. So > (most) other cases will remain unaffected by this adjustment of the > defaults. That isn't the case, people can take the defaults and adjust them. They don't expect the defaults to change underneath them. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#241080): https://lists.openembedded.org/g/openembedded-core/message/241080 Mute This Topic: https://lists.openembedded.org/mt/120174368/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
