On Tue, 7 Jul 2026 at 23:15, John Ripple via lists.openembedded.org <[email protected]> wrote: > + try: > + info['commit'] = repo.head.commit.hexsha > + info['commit_count'] = repo.head.commit.count() > + info['commit_time'] = repo.head.commit.committed_date > + except (ValueError, TypeError): > + pass
Suppressing generic exceptions like this to avoid a specific problem is problematic, as it can quietly suppress different, real problems. I'd say any layers handled by this function must have a commit, and if they don't it's a user error. How did this come up? Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#240574): https://lists.openembedded.org/g/openembedded-core/message/240574 Mute This Topic: https://lists.openembedded.org/mt/120164248/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
