On Fri, May 22, 2026 at 12:53 PM, Paul Barker wrote: > > On Fri, 2026-05-22 at 06:59 +0200, Aleksandar Nikolic via > lists.openembedded.org wrote: > >> From: Aleksandar Nikolic <[email protected]> >> >> In case wks file references nvme0n1, update_fstab() function creates wrong >> entries >> in /etc/fstab, as it is not adding prefix 'p' before the partition number >> (at the >> moment this happens only for mmcblk). This leads that entries in >> /etc/fstab start >> with: >> >> /dev/nvme0n11 >> /dev/nvme0n13 >> >> instead with: >> >> /dev/nvme0n1p1 >> /dev/nvme0n1p3 >> >> The patch fixes this as it extends the if condition and adds prefix 'p' >> for >> both mmcblk and nvme0n1. > > This is an interesting case for our backport policy, as wic is no longer > embedded within OE-core on wrynose or master. However, I think this > should be submitted against the standalone wic repository first (see the > readme [1] for contributing instructions) and we should get feedback > from the maintainer.
Yes, makes sense. I'll post a patch there as soon as I have added your suggestions. When/if it gets accepted we can backport it to scarthgap and whinlatter. > > [1]: https://git.yoctoproject.org/wic/tree/README.md?h=master > > This should also handle other NVMe devices beyond the first, what about > /dev/nvme1n1? Or an NVMe device with a second namespace /dev/nvme1n2? Thanks, will add your suggestions in the patch for the wic repository. Cheers, Aleksandar > > Best regards, > > -- > Paul Barker
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#237543): https://lists.openembedded.org/g/openembedded-core/message/237543 Mute This Topic: https://lists.openembedded.org/mt/119436831/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
