Hi Ross,

Thanks again for the review and good suggestion. That makes it even more 
simpler. What we need here is glibc-gconv-cp1251. I tested this RDEPEND change 
and all 748 tests pass now including bug-146. Also dropped the existence check 
as you suggested.

v3 is sent separately fixing these.

Best Regards,
Pratik

________________________________________
From: Ross Burton <[email protected]>
Sent: Wednesday, May 20, 2026 5:57 PM
To: Pratik Farkase
Cc: [email protected]; [email protected]
Subject: Re: [OE-core][PATCH v2] libxslt: add ptest support

On 18 May 2026, at 13:26, Pratik Farkase via lists.openembedded.org 
<[email protected]> wrote:
> +    for d in general REC REC2 documents encoding exslt extensions \
> +             keys namespaces numbers plugins reports; do
> +        if [ -d ${S}/tests/$d ]; then
> +            cp -r ${S}/tests/$d ${D}${PTEST_PATH}/tests/
> +        fi

Don’t check for existence here, we want to know if this list changes.

> +    done
> +
> +    # Remove encoding test that requires windows-1251 iconv support
> +    rm -f ${D}${PTEST_PATH}/tests/encoding/bug-146.*
> +}

I think you can solve this by just rdepending on glibc-charmap-cp1251 (which 
will need to be conditional on glibc).

Ross

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#237476): 
https://lists.openembedded.org/g/openembedded-core/message/237476
Mute This Topic: https://lists.openembedded.org/mt/119371617/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to