On Tue, 2025-01-21 at 09:12 +0100, Jan Strater-Büddefeld via lists.openembedded.org wrote:
Fixes [YOCTO #15579] This commit removes the LD_LIBRARY_PATH wrapper around `cargo`. Setting the LD_LIBRARY_PATH causes many problems. Some build scripts will not run because the build scripts execute binaries from the host system that are not compatible with the target libraries. Even a simple `cargo help build` can fail because it uses `less` internally, which should not be linked against the target libraries. There might be cases where the LD_LIBRARY_PATH is needed for some hosts, like the case described in 388e7cac9f90e79ce8c3c1683d8ee0f4df1bc907 but one can always set LD_LIBRARY_PATH manually if needed. A current working workaround without this commit would be always using `cargo.real` instead of `cargo`, which can lead to confusion. Signed-off-by: Jan Strater-Büddefeld <j...@mbs-solutions.de><mailto:j...@mbs-solutions.de> --- meta/recipes-devtools/rust/cargo_1.81.0.bb | 8 -------- 1 file changed, 8 deletions(-) That wrapper was added for a reason. Is that reason still valid and how do you plan to mitigate against the issues it was originally added for? The commit message needs to mention this. Cheers, Richard I have rebased the commit and reworded the commit message. Is the new patch better? Let me know, what else I can do. This is my first contribution to an open source project, so I'm not familiar with the process yet. Kindly regards, Jan Strater-Büddefeld
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#211980): https://lists.openembedded.org/g/openembedded-core/message/211980 Mute This Topic: https://lists.openembedded.org/mt/110730216/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
