Hi Harish,
On 16 Jan 2025, at 11:38, Sadineni, Harish via lists.openembedded.org
<Harish.Sadineni=windriver....@lists.openembedded.org> wrote:
> The change includes:
> - Prepending '${RUST_TARGET_SYS}' to 'rust.sh' to differentiate between
> target systems.
> - Moving the non-target-specific environment variables to 'nativesdk-cargo'
> and 'nativesdk-rust', instead of being managed by the cross-canadian recipe.
> - Removed the redundant cargo config file from the 'rust-cross-canadian.inc'
> file.
Can you split the last change into a separate commit? Makes it easier to
review independent changes, and revert selected pieces in the future if needed.
> + chown -R root.root ${D}
I know these chowns were in the original code but I don’t see why they’re
needed (in do_install you’re under pseudo, so new files will be created as
root). Please remove them.
Cheers,
Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#210151):
https://lists.openembedded.org/g/openembedded-core/message/210151
Mute This Topic: https://lists.openembedded.org/mt/110645381/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
