On 23.04.2012 17:31, Darren Hart wrote: > > On 04/17/2012 06:05 AM, Andreas Oberritter wrote: >> * depmod already gets executed by pkg_postinst_kernel-image. > > What if you install a module package after the initial system > installation? Don't you want the module install to run depmod?
If you look at the patch, you see that only the calls to cross-depmod get removed (which get called during do_rootfs). The behaviour of modules installed after the initial installation hasn't changed. What has changed in addition is that modules.bbclass' pkg_postinst doesn't return an error during do_rootfs, but instead behaves like pkg_postinst_modules from kernel.bbclass. Regards, Andreas > > -- > Darren > >> >> Signed-off-by: Andreas Oberritter <o...@opendreambox.org> >> --- >> meta/classes/kernel.bbclass | 4 +--- >> meta/classes/module.bbclass | 7 +++---- >> 2 files changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass >> index 3519e7c..c21ab96 100644 >> --- a/meta/classes/kernel.bbclass >> +++ b/meta/classes/kernel.bbclass >> @@ -276,9 +276,7 @@ fi >> } >> >> pkg_postinst_modules () { >> -if [ -n "$D" ]; then >> - ${HOST_PREFIX}depmod -A -b $D -F >> ${STAGING_KERNEL_DIR}/System.map-${KERNEL_VERSION} ${KERNEL_VERSION} >> -else >> +if [ -z "$D" ]; then >> depmod -a >> update-modules || true >> fi >> diff --git a/meta/classes/module.bbclass b/meta/classes/module.bbclass >> index 53c16b7..91628e4 100644 >> --- a/meta/classes/module.bbclass >> +++ b/meta/classes/module.bbclass >> @@ -37,15 +37,14 @@ module_do_install() { >> } >> >> pkg_postinst_append () { >> - if [ -n "$D" ]; then >> - exit 1 >> - fi >> +if [ -z "$D" ]; then >> depmod -a >> update-modules || true >> +fi >> } >> >> pkg_postrm_append () { >> - update-modules || true >> +update-modules || true >> } >> >> EXPORT_FUNCTIONS do_compile do_install > _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core