On Mon, 2024-12-09 at 18:38 +0100, Marco Felsch wrote: > On 24-12-09, Richard Purdie wrote: > > On Mon, 2024-12-09 at 17:22 +0000, Richard Purdie via > > lists.openembedded.org wrote: > > > Okay, thanks for the clarification. I'm not very deep into the > bitbake > core development. > > > > If we're hitting the "NULL prefix" code in icecc_version(), > > > wouldn't it > > > be better to special case pn == "no-pn" there, note that it is at > > > dependency parse time and return a dummy "parse-time-dummy- > > > icetarball.tgz" value? > > I used the current location (use_icecc) since it makes no sense to me > to > check for recipe names (disabled_recipes, enabled_recipes) if we > can't > use the PN value. > > > I meant to add, if we rewrite some of these functions in python, > > these > > issues would go away as we don't expand data in python functions. > > Now with your explanation it makes more sense to me why only > set_icecc_env() failed... Thanks a lot! > > > The modern way of doing much of this would be a python prefunc on > > the > > appropriate tasks. I have to wonder how many people are using icecc > > :/. > > Okay, I will give it a try with a python based prefunc.
Just wanted to say thanks for that patch, it looks like a neater way to fix this and likely other issues too. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#208781): https://lists.openembedded.org/g/openembedded-core/message/208781 Mute This Topic: https://lists.openembedded.org/mt/110009272/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
