On Mon, Dec 16, 2024 at 6:35 AM Antonin Godard <antonin.god...@bootlin.com>
wrote:
> Following commit a39a1f7cf78ad1ca07438bce634a47e970f25047
> ("kernel-yocto: allow early exit to configuration audit"), we can
> disable auditing of the kernel configuration by setting KMETA_AUDIT
> empty.
>
> Since the default value of this variables is "yes", use
> oe.types.boolean() so that it will also be disabled when setting it to
> "no", and avoid potential confusion.
>
That isn't the intent of the variable. It is being used as a flag here,
but it can also be used to encode other information.
Quite literally, if it is set to anything, the audit should happen. Only
when it is unset should it not.
Bruce
>
> Signed-off-by: Antonin Godard <antonin.god...@bootlin.com>
> ---
> meta/classes-recipe/kernel-yocto.bbclass | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/kernel-yocto.bbclass
> b/meta/classes-recipe/kernel-yocto.bbclass
> index
> a5d89dc2c8bc912539f7c9ffc25a2576920f580a..1493ba20a0c25df556df41fa4137ab17f67c91e7
> 100644
> --- a/meta/classes-recipe/kernel-yocto.bbclass
> +++ b/meta/classes-recipe/kernel-yocto.bbclass
> @@ -568,7 +568,9 @@ python do_config_analysis() {
> python do_kernel_configcheck() {
> import re, string, sys, subprocess
>
> - audit_flag = d.getVar( "KMETA_AUDIT" )
> + audit_flag = False
> + if d.getVar("KMETA_AUDIT"):
> + audit_flag = oe.types.boolean(d.getVar("KMETA_AUDIT"))
> if not audit_flag:
> bb.note( "kernel config audit disabled, skipping .." )
> return
>
> ---
> base-commit: e345b34703d4fa5e0bc9a82ac33b7c1fd84f99fe
> change-id: 20241216-kmeta-audit-vartrue-6650cb20f762
>
> Best regards,
> --
> Antonin Godard <antonin.god...@bootlin.com>
>
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#208762):
https://lists.openembedded.org/g/openembedded-core/message/208762
Mute This Topic: https://lists.openembedded.org/mt/110142731/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
