On Fri, 2024-12-06 at 16:45 +0800, Changqing Li via lists.openembedded.org
wrote:
> From: Changqing Li <changqing...@windriver.com>
>
> After following commit in meta-oe,
> [fe3ba7ac5c cryptsetup: demote udev runtime dependency to recommendation]
>
> bitbake lib32-cryptsetup will failed with error:
> ERROR: QA Issue: lib32-cryptsetup package lib32-cryptsetup - suspicious
> values 'udev lvm2' in RRECOMMENDS [multilib]
>
> This is because RRECOMMENDS is not extended with mlprefix, with
> this fix, RRECOMMENDS:lib32-cryptsetup is corrected.
>
> Without this fix:
> RRECOMMENDS:lib32-cryptsetup="kernel-module-aes-generic kernel-module-cbc
> kernel-module-dm-crypt kernel-module-md5 kernel-module-sha256-generic
> kernel-module-xts udev lvm2"
> Whith this fix:
> RRECOMMENDS:lib32-cryptsetup="kernel-module-aes-generic kernel-module-cbc
> kernel-module-dm-crypt kernel-module-md5 kernel-module-sha256-generic
> kernel-module-xts lib32-udev lib32-lvm2"
>
> Signed-off-by: Changqing Li <changqing...@windriver.com>
> ---
> meta/classes-global/base.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-global/base.bbclass
> b/meta/classes-global/base.bbclass
> index b81e61fdb7..3aaabb67e9 100644
> --- a/meta/classes-global/base.bbclass
> +++ b/meta/classes-global/base.bbclass
> @@ -471,7 +471,7 @@ python () {
> def appendVar(varname, appends):
> if not appends:
> return
> - if varname.find("DEPENDS") != -1:
> + if varname.find("DEPENDS") != -1 or varname.find("RRECOMMENDS")
> != -1:
> if bb.data.inherits_class('nativesdk', d) or
> bb.data.inherits_class('cross-canadian', d) :
> appends = expandFilter(appends, "", "nativesdk-")
> elif bb.data.inherits_class('native', d):
When proposing a change like this to something as core as base.bbclass,
you need to explain why the issue is occurring and why it hasn't been
seen before.
I couldn't see why this was a special case until I opened up
base.bbclass locally, then I see that appendVar is in the PACKAGECONFIG
processing block and that at least then lets me guess at the issue. I'm
going to guess that these RRECOMMENDS are being added by some
PACKAGECONFIG code. The commit message should mention that!
appendVar is called in the form:
appendVar('DEPENDS', extradeps)
appendVar('RDEPENDS:${PN}', extrardeps)
appendVar('RRECOMMENDS:${PN}', extrarrecs)
appendVar('PACKAGECONFIG_CONFARGS', extraconf)
so there are a specific list of entries being processed and you're
expanding that condition to include another of the cases.
I'd note that ".find() != -1" is old python and
varname.startswith("RRECOMMENDS") would be much nicer in modern code.
Cheers,
Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#208418):
https://lists.openembedded.org/g/openembedded-core/message/208418
Mute This Topic: https://lists.openembedded.org/mt/109954831/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
