On Mon, 25 Nov 2024 at 10:37, Ross Burton <ross.bur...@arm.com> wrote: > > On 25 Nov 2024, at 15:47, Dan McGregor via lists.openembedded.org > <danismostlikely=gmail....@lists.openembedded.org> wrote: > > > > From: Dan McGregor <dan.mcgre...@usask.ca> > > > > Ignore shared object names that differ from names we've already > > processed only by their version number. This assumes that the > > highest priority is first in the list, and ignores those later > > in the list if we've alredy found one. > > > > I saw this with the qrencode PACKAGECONFIG enabled. Its note lists > > both libqrencode.so.4 and libqrencode.so.3, which led to a packaging > > warning. > > I’m unconvinced that “just take the first one” is the right solution here. > What was the resulting dependency without this patch? Our qrencode recipe is > version 4.1.1 so libqrencode.so <http://libqrencode.so/>.4 should have found > the qrencode package, but libqrencode.so <http://libqrencode.so/>.3 shouldn’t > have found anything and so a dependency shouldn’t have been created. > > Unless my code is buggy in a different way, of course…
The dependency generated was correct. It found libqrencode.so.4, but the note called for both libqrencode.so.4 and libqrencode.so.3.. see https://github.com/systemd/systemd/blob/main/src/shared/qrcode-util.c#L28 When it then went looking for libqrencode.so.3 it didn't find anything, so emitted a warning about not finding libqrencode.so.3. The goal with this change is just to silence the warning if we've already found a package. > > Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#207799): https://lists.openembedded.org/g/openembedded-core/message/207799 Mute This Topic: https://lists.openembedded.org/mt/109773301/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
