On 11/21/24 12:10, Khem Raj wrote:
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know 
the content is safe.

On Wed, Nov 20, 2024 at 8:04 PM Changqing Li via
lists.openembedded.org
<changqing.li=windriver....@lists.openembedded.org>  wrote:

On 11/21/24 00:51, Ross Burton wrote:

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know 
the content is safe.

On 5 Nov 2024, at 10:12, Changqing Li via 
lists.openembedded.org<changqing.li=windriver....@lists.openembedded.org>  
wrote:

--- a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
+++ b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
@@ -37,6 +37,7 @@ do_configure:prepend () {
if [ ! -e ${S}/acinclude.m4 ]; then
cp ${S}/aclocal.m4 ${S}/acinclude.m4
fi
+ sed -i -e 's#@TIC@#:#g' ${S}/doc/Makefile.in
}

A brute-force sed feels ugly and prone to silent breakage.  Wouldn’t this work 
just as well:

EXTRA_OEMAKE = “TIC=true”

Hi, Ross

Thanks for advice.  But this @TIC@ cannot replaced by add configs like 
EXTRA_OEMAKE.

TIC is defined in configure.ac by "AC_PATH_PROG(TIC, tic, :) ", so TIC will be 
native tic path.

and during configure process, configure will replace @TIC@ in doc/Makefile.in 
with native tic path.

So in do_install stage, the doc/Makefile already have a hardcode native tic 
path, not variable $(TIC)

which could be replaced by pass argument. Seems no interface for us to pass 
argument to change TIC.

you can override this via setting ac_cv_path_TIC=path/to/tic in
EXTRA_OECONF or CACHED_CONFIGUREVARS

This way works. I will send a V2 later.

Just remembered,  I had tried to pass TIC=:  to configure before using sed,  but TIC=: cannot match as a path.

And didn't think of using ac_cv_path_TIC directly.

[snip]

e) case $TIC

    in [\\/]* | ?:[\\/]*)

    ac_cv_path_TIC="$TIC" # Let the user override the test with a path.

[snip]


@Khem, Ross,  Thanks a lot.


Regards

Changqing



Regards

Changqing

Ross




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#207509): 
https://lists.openembedded.org/g/openembedded-core/message/207509
Mute This Topic: https://lists.openembedded.org/mt/109403291/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to