Hi Alex,

Am Mittwoch, dem 06.11.2024 um 17:03 +0100 schrieb Alexander Kanavin:
> Can we rather make the affected recipe depend on the native tool rather than 
> the host one?

we could and I agree this would be the more correct way.
The only concern I have is that this would require adding dependencies for all 
potential compression
methods currently supported by barebox (lz4, lzo, gzip, xz).

Or I have to add some more pseudo-PACKAGECONFIG options and enable only lz4 by 
default.
However, I fear that this would quickly result in accidentally using the host 
tools again.
Not sure if there is local way of filtering out allowed host tools?..

> And pls file a ticket with barebox upstream or maybe the maintainer can 
> respond right here.

Thankfully, Justin already contributed the fix to barebox upstream in the 
meantime and as far as I
can see, it was quickly merged and should thus be part of the November release.

Regards, Enrico

> Alex
> 
> On Wed 6. Nov 2024 at 16.52, Justin Bronder via lists.openembedded.org
> <jsbronder=cold-front....@lists.openembedded.org> wrote:
> > On 06/11/24 07:50 +0000, Richard Purdie wrote:
> > > On Tue, 2024-11-05 at 10:37 -0500, Justin Bronder via 
> > > lists.openembedded.org wrote:
> > > > With bitbake commit 'bb: compress: use lz4 instead of lz4c' we require
> > > > lz4, not lz4c [1].  Going as far back as Ubuntu 16.04/Fedora 25, they
> > > > are packaged together so it should be safe to simply adjust the
> > > > requirement from lz4c to lz4.
> > > > 
> > > > Note that the two are largely the same, but upstream has considered lz4c
> > > > deprecated since at least 2018 [2].
> > > > 
> > > > 1. 
> > > > https://git.openembedded.org/bitbake/commit/?id=907472034b344e4eb73cfd43059a413469f52e1c
> > > > 2. https://github.com/lz4/lz4/pull/553
> > > > 
> > > > Signed-off-by: Justin Bronder <jsbron...@cold-front.org>
> > > > ---
> > > >  meta/conf/bitbake.conf | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > > > index eda505c861..14e761e2e7 100644
> > > > --- a/meta/conf/bitbake.conf
> > > > +++ b/meta/conf/bitbake.conf
> > > > @@ -517,7 +517,7 @@ HOSTTOOLS += " \
> > > >      [ ar as awk basename bash bunzip2 bzip2 cat chgrp chmod chown 
> > > > chrpath cmp comm cp cpio
> > > > \
> > > >      cpp cut date dd diff diffstat dirname du echo egrep env expand 
> > > > expr false \
> > > >      fgrep file find flock g++ gawk gcc getconf getopt git grep gunzip 
> > > > gzip \
> > > > -    head hostname iconv id install ld ldd ln ls lz4c make md5sum mkdir 
> > > > mkfifo mknod \
> > > > +    head hostname iconv id install ld ldd ln ls lz4 make md5sum mkdir 
> > > > mkfifo mknod \
> > > >      mktemp mv nm objcopy objdump od patch perl pr printf pwd \
> > > >      python3 pzstd ranlib readelf readlink realpath rm rmdir rpcgen sed 
> > > > seq sh \
> > > >      sha1sum sha224sum sha256sum sha384sum sha512sum \
> > > > 
> > > 
> > > This caused a failure in barebox:
> > > 
> > > https://valkyrie.yoctoproject.org/#/builders/23/builds/409/steps/14/logs/stdio
> > > 
> > 
> > I see, sorry about that.
> > 
> > What would be the recommended path forward?
> > 
> > - Add lz4c to HOSTTOOLS_NONFATAL so it's still symlinked.  This would fix 
> > barebox and any other
> > recipes that still depend on lz4c on distributions where lz4c is still 
> > packaged but leave others
> > without an early warning system.
> > - Submit patches to barebox and others to use lz4 instead of lz4c.  This is 
> > probably more
> > correct but will leave Tumbleweed unsupported by default with other distros 
> > to presumably
> > follow.
> > - Convince Tumbleweed (and others) to continue packaging lz4c.
> > 
> > 

-- 
Pengutronix e.K.                           | Enrico Jörns                |
Embedded Linux Consulting & Support        | https://www.pengutronix.de/ |
Steuerwalder Str. 21                       | Phone: +49-5121-206917-180  |
31137 Hildesheim, Germany                  | Fax:   +49-5121-206917-9    |
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#207048): 
https://lists.openembedded.org/g/openembedded-core/message/207048
Mute This Topic: https://lists.openembedded.org/mt/109427109/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to