The whole install_ptest_base task is deleted if PTEST_ENABLED is not set to 1, so yes it's unnecessary.
Generally, it helps to find the point in code history where the now-questionable code was introduced, check out the whole tree at that point and see if that code was necessary back then, e.g. if ptest class used to work differently. Alex On Tue, 3 Sept 2024 at 12:56, Robert P. J. Day via lists.openembedded.org <rpjday=crashcourse...@lists.openembedded.org> wrote: > > > another quirk in my travels through the ptest feature so i can write > a tutorial, i ran across precisely two OE recipes that check > PTEST_ENABLED in their definition of do_install_ptest(): > > https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/gettext/gettext_0.22.5.bb#n147 > https://git.openembedded.org/openembedded-core/tree/meta/recipes-devtools/elfutils/elfutils_0.191.bb#n68 > > that test *seems* unnecessary, or is there something particularly > subtle that might require that? i don't see any compelling reason to > have to check that variable. > > rday > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#204157): https://lists.openembedded.org/g/openembedded-core/message/204157 Mute This Topic: https://lists.openembedded.org/mt/108242664/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
