On Wed, 2024-05-22 at 15:19 +0200, Martin Jansa wrote:
> On Wed, May 22, 2024 at 3:09 PM Richard Purdie via
> > > The following code is part of the anonymous python() function in 
> > > base.bbclass:
> > > 
> > >     if os.path.normpath(d.getVar("WORKDIR")) != 
> > > os.path.normpath(d.getVar("S")):
> > >         d.appendVar("PSEUDO_IGNORE_PATHS", ",${S}")
> > >     if os.path.normpath(d.getVar("WORKDIR")) != 
> > > os.path.normpath(d.getVar("B")):
> > >         d.appendVar("PSEUDO_IGNORE_PATHS", ",${B}")
> > > 
> > > Since it is (or will be) an error to have S = "${WORKDIR}", it should now 
> > > be
> > > possible to move the addition of ${S} to PSEUDO_IGNORE_PATHS to 
> > > bitbake.conf.
> > 
> > Yes, we should be able to start finding and cleaning up things like
> > this.
> > 
> > > I also believe ${UNPACKDIR} should be added to PSEUDO_IGNORE_PATHS.
> > 
> > Why? I don't think we want UNPACKDIR there, we only need S.
> 
> There were recently couple issues with pseudo when the source file
> from something not unpacked under ${S} confuses pseudo when it sees
> the same file unpacked by do_unpack and then linked from
> package/usr/src/debug e.g.:
> 
> path mismatch [3 links]: ino 214373575 db
> 'opencv/4.5.5-r0/package/usr/src/debug/lib32-opencv/4.5.5-r0/contrib/modules/intensity_transform/src/bimef.cpp'
> req 'opencv/4.5.5-r0/contrib/modules/intensity_transform/src/bimef.cpp'.
> 
> which can be usually easily fixed by moving the additional files (or
> other repositories) to be unpacked/checked out as subdirectory under
> ${S} to make them ignored by pseudo as well.
> 
> As in:
> https://git.openembedded.org/meta-openembedded/commit/?h=kirkstone&id=da98a75f37830e69ded0207cc6c73182ab00ec50
> which moved ${WORKDIR}/contrib to ${WORKDIR}/git/contrib to avoid this issue.
> 
> But now with clearer separation thanks to ${UNPACKDIR} this whouldn't
> be needed if we add whole UNPACKDIR to PSEUDO_IGNORE_PATHS.
> 
> Is there any case when UNPACKDIR needs to be tracked by pseudo?

I'm thinking about this backwards, too many things in parallel. We
could add UNPACKDIR to there, yes. You'd really hope that isn't needed
though in general :/.

It may be time to think about switching the paths list to the ones we
want pseudo to cover rather than ignore though, which the creation of
UNPACKDIR and dropping S = WORKDIR further helps with.

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199755): 
https://lists.openembedded.org/g/openembedded-core/message/199755
Mute This Topic: https://lists.openembedded.org/mt/106239726/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to