On Mon, 8 Jan 2024 at 15:42, Jermain Horsman <jermain.hors...@nedap.com> wrote:
All the new options need longer, more detailed descriptions.
> + parser.add_argument('--update', '-u',
> + action='store_true',
> + help='Updates an existing layers setup.')
"Updates an existing layer setup json file with custom references
provided via --repository and --reference options instead of writing a
new json file."
> + parser.add_argument('--repository', '-p',
> + action='append',
> + help='Repository to customize, this requires a reference to be
> specified.\nThis option can be used multiple times.')
"Repository for which a custom reference provided with --reference
would be used. This option...".
> + parser.add_argument('--reference', '-r',
> + help="Reference to use when updating repositories.\nThe value
> can be any git reference, however it is up to the user to provide a valid
> value.\nThis option is only useful when using '--update'.")
"A custom reference to use for a repository (by default the currently
checked out commit id would be written out). This value can be any
reference that 'git checkout' would accept, and is not checked for
validity."
Drop the "This option is only useful when using '--update'." because
it's not accurate I think?
> I've named this option '--repository' as I would like to use '--update' with
> '--repository', without '--reference'
> at some point, in which case '--use-custom-reference' does not seem
> appropriate.
To be honest I think we should actually combine --repository and
-reference into one:
--use-custom-reference repo,reference
That way each repo can have its own reference, and all customization
can be done with a single command line invocation, which separate
--repository and --reference options do not allow. And this leaves
space for other options to be added later on.
Is comma (,) as a separator okay? Maybe : is better?
Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193449):
https://lists.openembedded.org/g/openembedded-core/message/193449
Mute This Topic: https://lists.openembedded.org/mt/103598114/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
