On Wed, 2023-11-01 at 12:01 +0100, Adrian Freihofer wrote: > Remove the image-combined-dbg.bbclass and make this the default > behavior for the rootfs-dbg. A rootfs-dbg with only debug symbols but > no executable binaries also causes problems with gdb, which is > probably the most common use case for the roofs-dbg. This change > simplifies and improves the user experience for a slightly larger > rootfs-dbg. > > If the rootfs-dbg contains a complete copy of the rootfs, it is also > usable for booting the target device over the network. This in turn > simplifies other use cases with e.g. the use of perf on a device > booted over the network. > > Signed-off-by: Adrian Freihofer <adrian.freiho...@siemens.com>
I'm being pressured for review on this so I'll just say what the problem is. I struggle to review this as off the top of my head, I can't remember the difference between "rootfs-dbg" or "image-combined- dbg". I understand the patch gets rid of one and the argument appears to be that gdb doesn't work well with the case that is removed. What isn't here is any reminder of what the differences are, or a pointer to the history which lead us to have two different modes in the first place. We presumably had a reason for adding it. That means in order to review it, I'd have to dig into the history and work out the differences, then work out why we added the two modes and then determine if they're still needed. What would help speed up review would be a pointer to the original commits and/or a summary of why the were added. A summary of the differences between the two modes would also help/ Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#190217): https://lists.openembedded.org/g/openembedded-core/message/190217 Mute This Topic: https://lists.openembedded.org/mt/102316026/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
