On Wed, Oct 18, 2023 at 1:49 PM chris.lapla...@agilent.com <chris.lapla...@agilent.com> wrote: > > > Ugh, actually this needs more work. If a recipe sets KBUILD_DEFCONFIG based > > on MACHINE overrides, then the no-override case will explode when we call > > 'kernel_pre_patch(localdata)'. Since in that case, KBUILD_DEFCONFIG will be > > unset. > > Actually, this approach is problematic in general because calling > do_kernel_metadata with the overrides changed isn't enough - we'd also have > to change MACHINE. E.g.: > > machine-a.conf: > KBUILD_DEFCONFIG:machine-a = "<blah>" > > machine-b.conf: > KBUILD_DEFCONFIG:machine-b = "<blah 2>" > > kernel-recipe.bb: > SRC_URI = "<kernel src>" > SRC_URI:append:machine-a = " <patches>" > SRC_URI:append:machine-b = " <different patches>" > > > Assuming MACHINE=machine-a in local.conf, then 'devtool modify > <kernel-recipe>' will fail to setup kernel metadata for 'machine-b'. > > Is setting up MACHINE too invasive? Or do we come up with a way of only > setting up override branches for overrides that are valid for the given > local.conf? I lean towards the latter approach for simplicity. >
I admit to not using devtool, and not following much of what has been going on in the series. But unless we are changing the machine for other devtool modify workflows, I wouldn't' see why we'd want to do that in the kernel either. Any type of valid override should work, as long as you get all the required variables setup for that override. To the error you mentioned in the original email, what exactly is blowing up ? KBUILD_DEFCONFIG is completely optional, and not used in most builds, so the empty / unset case shouldn't have any issues. Bruce > Thanks, > Chris -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189416): https://lists.openembedded.org/g/openembedded-core/message/189416 Mute This Topic: https://lists.openembedded.org/mt/101926734/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
