On Tue, Jun 27, 2023 at 11:59 AM Marek Vasut <ma...@denx.de> wrote: > > On 6/27/23 16:08, Steve Sakoman wrote: > > On Sun, Jun 25, 2023 at 3:50 AM Marek Vasut <ma...@denx.de> wrote: > >> > >> Replace the original "Wrong CRC with ASCII CRC for large files" > >> patch with upstream backport, and add additional fix on top of > >> the same problem which upstream detected and fixed. > > > > Your replacement patches are missing Upstream-Status and Signed-off-by tags: > > > > ERROR: cpio-2.13-r0 do_patch: Missing Upstream-Status in patch > > /home/steve/builds/poky-contrib-kirkstone/meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch > > Please add according to > > https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status > > . > > ERROR: cpio-2.13-r0 do_patch: Missing Upstream-Status in patch > > /home/steve/builds/poky-contrib-kirkstone/meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch > > Please add according to > > https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status > > Upstream-Status was indeed missed. > > What do I put into SoB line if the original patches have no SoB line > (which btw is common in other backports in OE-core and e.g. oelint-adv > warns about that too) ?
Probably common because only missing Upstream-Status generates an error! The Signed-off-by should be your name/email if you are kind enough to add it. Steve
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#183504): https://lists.openembedded.org/g/openembedded-core/message/183504 Mute This Topic: https://lists.openembedded.org/mt/99769144/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
