On 2012年03月13日 02:58, Mark Hatle wrote:
A few quick comments to match up with the patch 2/3 comments..
On 3/3/12 4:54 AM, Xiaofeng Yan wrote:
From: Xiaofeng Yan<xiaofeng....@windriver.com>
This is configuration file to point to what content a archive package
should include in the different stage of task by pointing to
different variable and
stage.
[YOCTO #1977]
Signed-off-by: Xiaofeng Yan<xiaofeng....@windriver.com>
Signed-off-by: Xiaofeng Yan<xiaofeng....@windriver.com>
---
meta/classes/archiver_configure.bbclass | 35
+++++++++++++++++++++++++++++++
1 files changed, 35 insertions(+), 0 deletions(-)
create mode 100644 meta/classes/archiver_configure.bbclass
diff --git a/meta/classes/archiver_configure.bbclass
b/meta/classes/archiver_configure.bbclass
new file mode 100644
index 0000000..c9892d3
--- /dev/null
+++ b/meta/classes/archiver_configure.bbclass
This seems odd that configuration items would be in a .bbclass file. I
would have expected the configuration to inherit the archiver, and
then either a default set of values be specified in the
archive.bbclass or in the bitbake.conf (or similar)....
As for the defaults below, I think they are fine....
I will define a default set in local.conf.sample in V2
@@ -0,0 +1,35 @@
+# This file is for getting tarball in different stage for sources,
patches, and logs by configuring
+# the following variable and tasks
+
+inherit archiver
+
+# SOURCE_ARCHIVE_PACKAGE_TYPE = {'tar','srpm'}
+SOURCE_ARCHIVE_PACKAGE_TYPE = 'tar'
+
+# SOURCE_ARCHIVE_LOG_WITH_SCRIPTS = {'logs_with_scripts', 'logs'}
+# String 'logs_with_scripts' include temp directory and .bb and .inc
file
+# String 'logs' only include temp
+SOURCE_ARCHIVE_LOG_WITH_SCRIPTS = 'logs_with_scripts'
+
+# PATCHES_ARCHIVE_WITH_SERIES = {'true', 'false'}
+# Strings 'true' means that patches including series files(series +
non-applying)
+# String 'false' means that no series and only archive applying patches
+PATCHES_ARCHIVE_WITH_SERIES = 'true'
+
+# Archive packages for copy-left
+#COPYLEFT_COMPLIANCE = 'true'
+
+# Open this item when you want to get original sources tarball with
patches
+do_unpack[postfuncs] += "do_archive_original_sources_patches "
Instead of do_unpack[postfuncs] would a do_patch[prefuncs] be better?
This would ensure that do_unpack and all other tasks between do_unpack
and do_patch were run first... then do we can archive the results..
Some bb files do some chages after do_unpack before do_patch. The
following bb files are the case. Perhaps some other bb files could
change some stuff before do_patch. So I archive sources codes in
do_unpack[postfuncs].
meta$ grep "do_unpack_append" . -nr
./recipes-core/eglibc/eglibc_2.15.bb:76:do_unpack_append() {
./recipes-core/eglibc/eglibc_2.13.bb:73:do_unpack_append() {
./recipes-sato/web/web_git.bb:19:do_unpack_append () {
./recipes-extended/ltp/ltp_20120104.bb:46:do_unpack_append() {
+
+# Open this item when you want to get tarball for patched sources
including patches
+#do_patch[postfuncs] += "do_archive_patched_sources "
Perhaps the same here between do_patch and do_configure...
--Mark
+
+# Open this item when you want to get tarball for configured sources
including patches
+#do_configure[postfuncs] += "do_archive_configured_sources "
+
+# Open this item when you want to get tarball for logs tarball
+do_package_write_rpm[prefuncs] += "do_archive_scripts_logs "
+
+# Get dump date and create diff file
+do_package_write_rpm[postfuncs] += "do_dumpdata_create_diff_gz "
-- 1.7.0.4 _______________________________________________
Openembedded-core
mailing list Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
