Probably just fell through a crack, I’ve queued it locally for testing.
Sorry about that!
Ross
> On 9 Jun 2023, at 10:37, Etienne Cordonnier via lists.openembedded.org
> <ecordonnier=snap....@lists.openembedded.org> wrote:
>
> Hello,
> is everything OK with the patch? Is there anything blocking a merge?
>
> On Fri, May 26, 2023 at 1:52 PM <ecordonn...@snap.com> wrote:
> From: Etienne Cordonnier <ecordonn...@snap.com>
>
> 2 issues:
> - the .so extension is hard-coded, and therefore the libxcryt package
> compiled with
> meta-darwin is empty, because the dylib files are not contained in
> FILES_${PN}
> - nothing actually produces a file libcrypt-*.so (the symlink file is
> libcrypt.so, without dash), thus
> defining FILES:${PN} manually to contain libcrypt-*.so has no effect.
>
> Signed-off-by: Etienne Cordonnier <ecordonn...@snap.com>
> ---
> meta/recipes-core/libxcrypt/libxcrypt.inc | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc
> b/meta/recipes-core/libxcrypt/libxcrypt.inc
> index 61b0381076..454a55d73d 100644
> --- a/meta/recipes-core/libxcrypt/libxcrypt.inc
> +++ b/meta/recipes-core/libxcrypt/libxcrypt.inc
> @@ -17,12 +17,6 @@ SRC_URI += "file://fix_cflags_handling.patch"
>
> PROVIDES = "virtual/crypt"
>
> -FILES:${PN} = "${libdir}/libcrypt*.so.* \
> - ${libdir}/libcrypt-*.so \
> - ${libdir}/libowcrypt*.so.* \
> - ${libdir}/libowcrypt-*.so \
> -"
> -
> S = "${WORKDIR}/git"
>
> BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}"
> --
> 2.36.1.vfs.0.0
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#182559):
https://lists.openembedded.org/g/openembedded-core/message/182559
Mute This Topic: https://lists.openembedded.org/mt/99149665/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
