On 4/5/23 08:48, Nicolas Dechesne wrote:
On Tue, Apr 4, 2023 at 11:36 PM Marek Vasut <ma...@denx.de> wrote:
In case a LAYERDEPENDS of a tested layer contains a dependency which is
present in additional layers, such dependency does not get pulled into
the layer test as a dependency be default and instead of YCL stops and
reports it cannot find dependent layers.
Hmm. I know this script is slightly (!) convoluted.
Well ... yes.
But I think this is done 'by design'. Since you are expected to list all
your dependencies with --dependency when you are testing a layer.
I am not sure that is correct. I believe the script is designed to
attempt to look up the dependencies of a layer automatically. That is
what the --additional-layers parameter is for, to specify the search
paths for the automatic layer dependency lookup. The --dependency is
there to hard-include a layer in the test, e.g. in case it cannot be
automatically detected because that dependency (layer) is somehow not
resolvable.
At least that is my understanding.
And the result then is, you can have a directory with various layers,
but the YCL with --additional-layers pointed into that directory will
only pick the layers which are really required for validation of that
tested layer, not the rest of them layers in that directory, which makes
YCL runtime shorter . And that way, YCL can be used to test multiple
arbitrary layers, which is useful in CI.
An example of this is a layer with LAYERDEPENDS = " core openembedded-core
"
and then by running YCL on such layer using the following invocation:
$ yocto-check-layer -d --additional-layers ../meta-openembedded/ --
../meta-board-distro
In this specific example, you are supposed to use --dependency
../meta-openembedded instead of --additional-layers, no?
I don't think so, the YCL should auto-lookup and auto-add the layers
into dependencies from --additional-layers. That is my understanding of
what --additional-layers is for, to do the auto-lookup/auto-add without
having to explicitly list the dependencies on command line.
--additional-layers (see 31e53430f1bb6f73b82698b20ef7f1047313214a) is
supposed to bring extra layers when parsing/testing to mimic a full distro
or to manually force optional layers to be present. But --dependency is
still required to contain all potential dependencies.
Errr, uhhh.
That is really weird, the first question which comes to my mind
regarding that commit message is -- why not use --dependency to cover
those use cases listed in the commit message.
The second question which comes to my mind is, why does the
additional-layers do automatic layer look up (based on LAYERDEPENDS) in
the specified additional-layer directories, but then fails to actually
add those layers into the build during the test (I think maybe that is
what I am solving with this patch, without describing it well).
Well that turned out to be a wall of text too, sigh ...
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#179735):
https://lists.openembedded.org/g/openembedded-core/message/179735
Mute This Topic: https://lists.openembedded.org/mt/98069983/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
