Hi Peter, On Thu, 19 Jan 2023 10:29:26 +0100 "Luca Ceresoli via lists.openembedded.org" <luca.ceresoli=bootlin....@lists.openembedded.org> wrote:
> Hello Peter, > > On Wed, 18 Jan 2023 22:22:22 +0000 > "Peter Kjellerstedt" <peter.kjellerst...@axis.com> wrote: > > > > -----Original Message----- > > > From: Luca Ceresoli <luca.ceres...@bootlin.com> > > > Sent: den 18 januari 2023 17:22 > > > To: Peter Kjellerstedt <peter.kjellerst...@axis.com> > > > Cc: openembedded-core@lists.openembedded.org; Richard Purdie > > > <richard.pur...@linuxfoundation.org> > > > Subject: Re: [OE-core] [PATCH] librsvg: Only enable the Vala bindings if > > > GObject Introspection is enabled > > > > > > Hello Peter, > > > > > > On Wed, 18 Jan 2023 12:27:59 +0100 > > > "Peter Kjellerstedt" <peter.kjellerst...@axis.com> wrote: > > > > > > > This avoids the following error: > > > > > > > > configure: error: Vala bindings require GObject Introspection > > > > > > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerst...@axis.com> > > > > > > A different patch [0] to address the same bug is already in my testing > > > branch and is possibly being merged soon on master by Richard. Can you > > > please check whether your think your patch is better and let us know? > > > > I had not seen that patch when I sent mine. I think mine is a little better > > since it defines and uses a PACKAGECONFIG for the vala support, which > > should > > make it easier for anyone wanting to, e.g., disable the vala support even > > if > > it is enabled by default. > > Indeed. I'm replacing Alex's patch with yours in my testing branch in > order to have both tested. None is on master at the moment. > I'm afraid testing with this patch applied caused lots of autobuilder failures: https://autobuilder.yoctoproject.org/typhoon/#/builders/62/builds/6553/steps/12/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/6551/steps/11/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/6443/steps/12/logs/stdio ...and more So I removed it from my testing branch and got the patch by Alex again. You'd be welcome to send a fixed version of your patch. -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#176167): https://lists.openembedded.org/g/openembedded-core/message/176167 Mute This Topic: https://lists.openembedded.org/mt/96351645/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
