On Sat, 2022-12-24 at 17:59 +0100, Alexander Kanavin wrote:
> qemu 7.2 no longer carries libslirp in-tree, and so
> it has to be provided externally.
> 
> Signed-off-by: Alexander Kanavin <a...@linutronix.de>
> ---
>  meta/conf/distro/include/maintainers.inc       |  1 +
>  .../recipes-connectivity/slirp/libslirp_git.bb | 18 ++++++++++++++++++
>  2 files changed, 19 insertions(+)
>  create mode 100644 meta/recipes-connectivity/slirp/libslirp_git.bb
> 
> diff --git a/meta/conf/distro/include/maintainers.inc 
> b/meta/conf/distro/include/maintainers.inc
> index 66797db02c..be96123ce6 100644
> --- a/meta/conf/distro/include/maintainers.inc
> +++ b/meta/conf/distro/include/maintainers.inc
> @@ -382,6 +382,7 @@ RECIPE_MAINTAINER:pn-libsamplerate0 = "Unassigned 
> <unassig...@yoctoproject.org>"
>  RECIPE_MAINTAINER:pn-libsdl2 = "Yi Zhao <yi.z...@windriver.com>"
>  RECIPE_MAINTAINER:pn-libseccomp = "Unassigned <unassig...@yoctoproject.org>"
>  RECIPE_MAINTAINER:pn-libsecret = "Alexander Kanavin <alex.kana...@gmail.com>"
> +RECIPE_MAINTAINER:pn-libslirp = "Unassigned <unassig...@yoctoproject.org>"
>  RECIPE_MAINTAINER:pn-libsm = "Unassigned <unassig...@yoctoproject.org>"
>  RECIPE_MAINTAINER:pn-libsndfile1 = "Unassigned <unassig...@yoctoproject.org>"
>  RECIPE_MAINTAINER:pn-libsolv = "Anuj Mittal <anuj.mit...@intel.com>"
> diff --git a/meta/recipes-connectivity/slirp/libslirp_git.bb 
> b/meta/recipes-connectivity/slirp/libslirp_git.bb
> new file mode 100644
> index 0000000000..334b786b9b
> --- /dev/null
> +++ b/meta/recipes-connectivity/slirp/libslirp_git.bb
> @@ -0,0 +1,18 @@
> +SUMMARY = "A general purpose TCP-IP emulator"
> +DESCRIPTION = "A general purpose TCP-IP emulator used by virtual machine 
> hypervisors to provide virtual networking services."
> +HOMEPAGE = "https://gitlab.freedesktop.org/slirp/libslirp";
> +LICENSE = "BSD-3-Clause & MIT"
> +LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=bca0186b14e6b05e338e729f106db727"
> +
> +SRC_URI = 
> "git://gitlab.freedesktop.org/slirp/libslirp.git;protocol=https;branch=master"
> +SRCREV = "3ad1710a96678fe79066b1469cead4058713a1d9"
> +PV = "4.7.0"
> +S = "${WORKDIR}/git"
> +
> +DEPENDS = " \
> +    glib-2.0 \
> +"
> +
> +inherit meson pkgconfig
> +
> +BBCLASSEXTEND = "native nativesdk"

I did merge this to core since the qemu upgrade has some potential wins
for us and is fairly important to get in. I probably shouldn't have
done as people are now upset, we're now seeing autobuilder failures,
people are on vacation and the issues won't be fixed until mid January.

I've had some feedback about the way this was handled. In future things
might be smoother if we:

a) make sure the maintainers of other layers containing such recipes 
   are cc'd on the changes.
b) mention in the commit which layer a recipe came from and who worked 
   on the underlying code
c) mention any changes made to merge to core
d) time things outside of holidays

Yes, it is a pain to do some of these things and sightly more work, but
leaving the issues to me isn't much fun either. I don't think anything
was intended by anything, it was mainly a desire to keep core up to
take and be able to take advantaged of new features in qemu.

I am very much aware that during holidays, people have different time
availability and this sometimes works in favour of productivity,
sometimes against it. I need to balance getting patch movement and
feedback back to contributors with some people taking a proper break
and it is hard to get right.

For the record, looking at a diff, the changes in this submission
appear to be:

* Upgrade from 4.6.1+git -> 4.7.0
* Addition of BBCLASSEXTEND for native/nativesdk
* Add DESCRIPTION and HOMEPAGE

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#175066): 
https://lists.openembedded.org/g/openembedded-core/message/175066
Mute This Topic: https://lists.openembedded.org/mt/95864516/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to