On Thu, 10 Nov 2022 at 21:42, Jordan Crouse via lists.openembedded.org
<jorcrous=amazon....@lists.openembedded.org> wrote:
> +DEPENDS += "vulkan-headers"
> +DEPENDS += "spirv-headers spirv-tools"
> +DEPENDS += "vulkan-loader"
> +DEPENDS += "glslang"
This should be squashed into a single line.
> +
> +EXTRA_OECMAKE = "\
> + -DBUILD_TESTS=OFF \
> + -DPYTHON_EXECUTABLE=${HOSTTOOLS_DIR}/python3 \
> + -DASSEMBLER_WORKS=FALSE \
> + -DVULKAN_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \
> + -DGLSLANG_INSTALL_DIR=${STAGING_DATADIR} \
> + -DSPIRV_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \
> + -DUSE_ROBIN_HOOD_HASHING=OFF \
> + "
Some of the choices here would be good to explain in the commit
message. What is this 'robin hood hashing' and why do we not want it?
:)
> +
> +PACKAGECONFIG[x11] = "-DBUILD_WSI_XLIB_SUPPORT=ON
> -DBUILD_WSI_XCB_SUPPORT=ON, -DBUILD_WSI_XLIB_SUPPORT=OFF
> -DBUILD_WSI_XCB_SUPPORT=OFF, libxcb libx11 libxrandr"
> +PACKAGECONFIG[wayland] = "-DBUILD_WSI_WAYLAND_SUPPORT=ON,
> -DBUILD_WSI_WAYLAND_SUPPORT=OFF, wayland"
These should be enabled by default subject to DISTRO_FEATURES.
> +FILES:${PN} += "/usr/share/vulkan/ /usr/lib/"
> +
> +INSANE_SKIP:${PN} += " ldflags"
> +INHIBIT_PACKAGE_STRIP = "1"
> +INHIBIT_SYSROOT_STRIP = "1"
> +SOLIBS = ".so"
> +FILES_SOLIBSDEV = ""
All of the above should be removed. If there are error messages due to
that, please show them, and we'll figure out how to address them
properly.
New recipes also need a meta/conf/distro/inclue/maintainers.inc entry.
Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#173110):
https://lists.openembedded.org/g/openembedded-core/message/173110
Mute This Topic: https://lists.openembedded.org/mt/94945225/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
