Hi Ross, Thanks for the feedback.
Can you point to the right repo to update? Just to make sure that I understand the concern, you are not referring to https://github.com/openembedded/meta-openembedded/pull/597, right? I am making changes to http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-connectivity/openssh/openssh_9.0p1.bb which I thought is part of oe-core. @Tristan Lelong <tlel...@google.com> is the maintainer for hiba and is okay with the change. Do you have any suggestions on installing it to just the sysroot in openssh while using it from the hiba recipe? I was not able to do that when I tried it. Thanks, Willy Tu On Fri, Oct 21, 2022 at 7:59 AM Ross Burton <ross.bur...@arm.com> wrote: > Hi, > > oe-core doesn’t accept merge requests on the github mirrors, and you > pushed to meta-oe, which is a different repository. > > >> + if ${@bb.utils.contains('DISTRO_FEATURES', 'opensshinternals', > 'true', 'false', d)}; then > > This should be a PACKAGECONFIG, as it’s not a distro-wide setting. > > >> + install -d ${D}${includedir}/ssh > >> + install -d ${D}${includedir}/ssh/openbsd-compat > >> + install -m0644 ${S}/*.h ${D}${includedir}/ssh > >> + install -m0644 ${S}/openbsd-compat/*.h > ${D}${includedir}/ssh/openbsd-compat > >> + > >> + install -d ${D}${libdir} > >> + install -m0644 ${S}/libssh.a ${D}${libdir} > >> + install -m0644 ${S}/openbsd-compat/libopenbsd-compat.a ${D}${libdir} > >> + fi > > So you’re installing bits of the SSH source into the *target* packages > because one piece of software needs the build tree. This is clearly an > unsupported use of openssh, as the hiba build instructions literally say > “build openssh, then point hiba’s configure at that build tree”. If > > I suggest a better approach would be to have a bbappend in your layer > which adds the files you need to *just the sysroot*, so the target packages > are unaltered. > > Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#172034): https://lists.openembedded.org/g/openembedded-core/message/172034 Mute This Topic: https://lists.openembedded.org/mt/94475279/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
