Hi John,
This approach doesn't seem correct, and we're observing build failures when
cherry-picked onto latest dunfell.
What is the cwd for this line? On dunfell, it's wherever bitbake was started
right? Which might be totally unrelated to the recipe.
+ if os.path.exists(".gitmodules"):
Parsing git config this way
+ submodule_helper = subprocess.check_output(["git", "config", "--file",
".gitmodules", "--get-regexp", "path"], cwd=s_dir, env=env).decode("utf-8")
will only ever find submodules if srcdir/EXTERNALSRC is also the superproject
top-level, unlike the previous method which found all submodules in the
superproject containing the srcdir/EXTERNALSRC.
externalsrc recipes may point to a subdirectory of the containing superproject
(in fact, multiple externalsrc recipes may refer to different subdirectories in
the same superproject).
Also, parsing git config enumerates inactive submodules, which appears to be
ignored but I think should have been called out in the commit log.
Regards,
Peter Hurley
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#171589):
https://lists.openembedded.org/g/openembedded-core/message/171589
Mute This Topic: https://lists.openembedded.org/mt/93979781/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
