HI Alexander, The recipe is tested for native and target. I'll make v2 with the remarks.
br On Sat, Aug 27, 2022 at 6:20 PM Alexander Kanavin <alex.kana...@gmail.com> wrote: > On Sat, 27 Aug 2022 at 10:29, jan vermaete <jan.verma...@gmail.com> wrote: > > The recipe is currently in master-next. > > > https://patchwork.yoctoproject.org/project/oe/patch/20220826195403.893639-1-jan.verma...@gmail.com/ > > > > Could you review? > > I think Khem's review covers what I wanted to say. > > > What I don't know is how to prove the executables used in the script of > makeself are those of yocto and not those of the host system. > > E.g. zstd is used by the script as 'zstd' ( > https://github.com/megastep/makeself/blob/master/makeself.sh#L535). > > But zstd itself is set in the HOSTTOOLS of Yocto > > In either case zstd will be in PATH, so it should simply work. > HOSTTOOLS will also refuse to proceed if anything in the list is not > yet installed on the host. But didn't you test the recipe? > > Alex > -- Jan Vermaete “Success is a self-correcting phenomenom.” -- Gary Hamel
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#169988): https://lists.openembedded.org/g/openembedded-core/message/169988 Mute This Topic: https://lists.openembedded.org/mt/92997365/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
