On 24 Aug 2022, at 13:09, Quentin Schulz via lists.openembedded.org <quentin.schulz=theobroma-systems....@lists.openembedded.org> wrote: > > Hi all, > > On 8/24/22 11:51, Luca Ceresoli via lists.openembedded.org wrote: >> Hello Markus, >> On Wed, 24 Aug 2022 10:56:54 +0200 >> "Markus Volk" <f_...@t-online.de> wrote: >>> Hello Luca, >>> >>> Am Mi, 24. Aug 2022 um 10:54:40 +0200 schrieb Luca Ceresoli >>> <luca.ceres...@bootlin.com>: >>>> I would think iwd should be an rdepends, not an rrecommends. Any reson >>>> for that? Or is it just an unintended extra ','? >>> >>> Only reason for this was the fact, that iwd is not in oe-core so it >>> felt wrong somehow to set it RDEPEND >> I see, that's fine, but I wonder whether this should be clarified in a >> comment. I'll be taking the patch for testing as is anyway. > > IIRC the policy is to have a default configuration working. It is fine to > have PACKAGECONFIG options with dependencies on recipes/packages not in the > same layer. > > Here, if someone builds with NO_RECOMMENDATIONS to have a minimal setup but > have iwd as WIRELESS_DAEMON, connman won't work because the package won't be > added to the image, it'll be a bit harder to debug than a build failing > because iwd recipe could not be found (especially since I also didn't notice > the additional comma).
Even worse: I can enable iwd in connman without meta-oe. As there’s no DEPENDS it will build find, the recommendation won’t pull in anything, but connman doesn’t work. Enabling IWD must RDEPEND on iwd. Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#169856): https://lists.openembedded.org/g/openembedded-core/message/169856 Mute This Topic: https://lists.openembedded.org/mt/93208331/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
