On Tue, Aug 9, 2022 at 7:14 AM Richard Purdie
<richard.pur...@linuxfoundation.org> wrote:
>
> After this commit in the mainline kernel, the quoting is different in
> auto.conf
> compared to .config:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=129ab0d2d9f38b9d43df35235fc66c6740d6928b
>
> We therefore can't just copy one over the other or it leads to syntax/quoting
> errors. We end up running make prepare anyway in all our tests so drop
> this copy for fix 5.19 kernels.
It is safe to stop doing this manipulation now.
But I am curious, I was running on-target tests for 5.19+ and didn't
have any issues, what is breaking that I managed to miss ?
There is a risk that if the .cmd files start regenerating because of
this missing, or the different timestamp, that we'll have issues. But
putting it through the AB should show us if that is true.
Bruce
>
> Signed-off-by: Richard Purdie <richard.pur...@linuxfoundation.org>
> ---
> meta/recipes-kernel/linux/kernel-devsrc.bb | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb
> b/meta/recipes-kernel/linux/kernel-devsrc.bb
> index a38d35e82ae..46d706b955f 100644
> --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> @@ -308,9 +308,6 @@ do_install() {
> # external modules can be built
> touch -r $kerneldir/build/Makefile
> $kerneldir/build/include/generated/uapi/linux/version.h
>
> - # Copy .config to include/config/auto.conf so "make prepare" is
> unnecessary.
> - cp $kerneldir/build/.config $kerneldir/build/include/config/auto.conf
> -
> # make sure these are at least as old as the .config, or rebuilds will
> trigger
> touch -r $kerneldir/build/.config
> $kerneldir/build/include/generated/autoconf.h 2>/dev/null || :
> touch -r $kerneldir/build/.config
> $kerneldir/build/include/config/auto.conf* 2>/dev/null || :
> --
> 2.34.1
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#169148):
https://lists.openembedded.org/g/openembedded-core/message/169148
Mute This Topic: https://lists.openembedded.org/mt/92912494/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
