On Mon, 2022-07-11 at 19:54 +0530, Pgowda wrote:
> From: pgowda <pgowda....@gmail.com>
> 
> Upstream-Status: Backport 
> [https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9234cdca6ee88badfc00297e72f13dac4e540c79]
> 
> Signed-off-by: pgowda <pgowda....@gmail.com>
> ---
>  meta/recipes-devtools/gcc/gcc-12.1.inc        |  1 +
>  .../gcc/gcc/0026-rust-recursion-limit.patch   | 92 +++++++++++++++++++
>  2 files changed, 93 insertions(+)
>  create mode 100644 
> meta/recipes-devtools/gcc/gcc/0026-rust-recursion-limit.patch

The patch is fine but the commit message needs work. The shortlog
whitespace is wrong and it needs to say that 105039 is a gcc bug, that
it is related to the rust demangler. The commit log should really say
why we need this as well. The upstream status should be in the patch
itself (which it is), not in the commit log. The URL to the upsteam fix
is ok though.

Since we'd tested this, I fixed the commit log in this case so you can
have a look at what I merged as an example of how it should look.

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#168027): 
https://lists.openembedded.org/g/openembedded-core/message/168027
Mute This Topic: https://lists.openembedded.org/mt/92310962/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to