On Mon, Jul 11, 2022 at 09:58:38AM +0100, Richard Purdie wrote: > On Mon, 2022-07-11 at 10:53 +0200, Sean Nyekjaer wrote: > > On Mon, Jul 11, 2022 at 09:46:58AM +0100, Richard Purdie wrote: > > > On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote: > > > > Signed-off-by: Sean Nyekjaer <s...@geanix.com> > > > > --- > > > > meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++ > > > > 1 file changed, 15 insertions(+) > > > > create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb > > > > > > I can see what this does, but why? Who would want this and why? There > > > is no detail in the commit messages. Also no maintainers entry which > > > will break QA checks. > > > > > > Cheers, > > > > > > Richard > > > > > > > > > > Hi Richard, > > > > We have some software that depends on minizip. > > I don't know if an extra package zlib-minizip or this was the prefered > > way to add it? > > I think an extra package on the existing recipe may be simpler and > easier maintenance. > > Commit messages do need a bit more information in them too, it isn't > enough to say what something does, it needs to say why. > > Cheers, > > Richard
I think it will be quite hacky to do it as one recipe, as zlib and minizip is to seperate autotools projects and zlib isn't even compatible with the autotools class. I could something with addtask but I don't think it will be very readable. Any ideas? /Sean
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#167881): https://lists.openembedded.org/g/openembedded-core/message/167881 Mute This Topic: https://lists.openembedded.org/mt/92305640/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
