After re-thinking this is the correct version of the patch. We need to
ignore_status because we are asserting that it actually fails. Otherwise
the bitbake() will fail the test on the desired failure.
Paulo Neves
On 7/4/22 16:30, Richard Purdie wrote:
On Mon, 2022-07-04 at 16:28 +0200, Paulo Neves wrote:
On 7/4/22 16:16, Richard Purdie wrote:
On Sun, 2022-07-03 at 13:41 +0200, Paulo Neves wrote:
bitbake ran but we incorrectly did not assert the exit status needs to
be non 0. Now all sysroot tests commands expected to fail are verified
to do so.
Signed-off-by: Paulo Neves <ptsne...@gmail.com>
---
meta/lib/oeqa/selftest/cases/sysroot.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meta/lib/oeqa/selftest/cases/sysroot.py
b/meta/lib/oeqa/selftest/cases/sysroot.py
index 588fc8c713..294ba4a4a0 100644
--- a/meta/lib/oeqa/selftest/cases/sysroot.py
+++ b/meta/lib/oeqa/selftest/cases/sysroot.py
@@ -45,6 +45,7 @@ TESTSTRING:pn-sysroot-test-arch2 = "%s"
expected = "maximum shebang size exceeded, the maximum size is 128.
[shebang-size]"
res = bitbake("sysroot-shebang-test-native -c populate_sysroot",
ignore_status=True)
self.assertTrue(expected in res.output, msg=res.output)
+ self.assertTrue(res.status != 0)
def test_sysroot_la(self):
"""
I did have a question on this patch. Wouldn't it be simpler to remove
the "ignore_status=True" from the bitbake() call?
Cheers,
Richard
You are right. I guess the assert is more explicit and with the removal
of the ignore_status it becomes implicit. Let me know if you want me to
remove the assert and the ignore status and will submit a v2.
Please, I think that would be cleaner.
Cheers,
Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#167785):
https://lists.openembedded.org/g/openembedded-core/message/167785
Mute This Topic: https://lists.openembedded.org/mt/92145212/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
