On 11/4/21 09:35, Mikko Rapeli wrote:
On Thu, Nov 04, 2021 at 02:02:57PM +0000, Richard Purdie wrote:
Combining :append with += rarely makes sense. Improve it to use the standard
format (and tweak the implied spacing).
Maybe I'm silly but I find :append with += safer to do than manually remembring
to add the space character.
I tend to agree; hence why I wrote it that way in the original patch.
But I'm not going to defend the practice in this case, so ACK from me
either way.
I'm intending to drop this recipe warning after the opkg_0.5.0 release
in December. So the recipe-as-written will only exist in the mainline
for another few months.
Signed-off-by: Richard Purdie <richard.pur...@linuxfoundation.org>
---
meta/recipes-devtools/opkg/opkg_0.4.5.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/opkg/opkg_0.4.5.bb
b/meta/recipes-devtools/opkg/opkg_0.4.5.bb
index 2760fc58786..8af047a51ff 100644
--- a/meta/recipes-devtools/opkg/opkg_0.4.5.bb
+++ b/meta/recipes-devtools/opkg/opkg_0.4.5.bb
@@ -60,7 +60,7 @@ do_install_ptest () {
sed -i -e '/@PYTHONPATH=. $(PYTHON) $^/a\\t@if [ "$$?" != "0" ];then echo
"FAIL:"$^;else echo "PASS:"$^;fi' ${D}${PTEST_PATH}/tests/Makefile
}
-WARN_QA:append += "openssl-deprecation"
+WARN_QA:append = " openssl-deprecation"
QAPKGTEST[openssl-deprecation] = "package_qa_check_openssl_deprecation"
def package_qa_check_openssl_deprecation (package, d, messages):
sane = True
--
2.32.0
Thanks,
--
Alex Stewart
Software Engineer - NI Real-Time OS
NI (National Instruments)
alex.stew...@ni.com
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#157877):
https://lists.openembedded.org/g/openembedded-core/message/157877
Mute This Topic: https://lists.openembedded.org/mt/86816265/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
