On Tue, Oct 26, 2021 at 10:07 PM Alexander Kanavin <alex.kana...@gmail.com> wrote:
> On Tue, 26 Oct 2021 at 21:38, Martin Jansa <martin.ja...@gmail.com> wrote: > >> 0200 >> >>> +Subject: [PATCH] ANGLE: do not enable SSE on x86 >>> + >>> +The code does not actually build there. >>> + >>> +Upstream-Status: Pending >>> +Signed-off-by: Alexander Kanavin <a...@linutronix.de> >>> +--- >>> + Source/ThirdParty/ANGLE/src/common/platform.h | 2 +- >>> + 1 file changed, 1 insertion(+), 1 deletion(-) >>> + >>> +diff --git a/Source/ThirdParty/ANGLE/src/common/platform.h >>> b/Source/ThirdParty/ANGLE/src/common/platform.h >>> +index 41f3cf4f..cab85a82 100644 >>> +--- a/Source/ThirdParty/ANGLE/src/common/platform.h >>> ++++ b/Source/ThirdParty/ANGLE/src/common/platform.h >>> +@@ -89,7 +89,7 @@ >>> + #if defined(_MSC_VER) && !defined(_M_ARM) && !defined(_M_ARM64) >>> + # include <intrin.h> >>> + # define ANGLE_USE_SSE >>> +-#elif defined(__GNUC__) && (defined(__x86_64__) || defined(__i386__)) >>> ++#elif defined(__GNUC__) && (defined(__x86_64__)) >>> + # include <x86intrin.h> >>> + # define ANGLE_USE_SSE >>> + #endif >>> >> >> Can you improve the commit message of this patch to show what "does not >> actually build there"? >> >> Because it fails to build here for qemux86 with: >> >> webkitgtk/2.34.0-r0/webkitgtk-2.34.0/Source/ThirdParty/ANGLE/src/libANGLE/Constants.h:20:7: >> error: 'size_t' does not name a type >> 20 | const size_t kDefaultMaxProgramCacheMemoryBytes = 0; >> | ^~~~~~ >> >> and deleting this patch fixes the build. >> > > Is it in the same 'building nodistro without enabling opengl' setup? > Please try to use plain poky, with opengl, and you'll see the issue. > No, this one was with opengl enabled, which was failing in do_configure do to missing gperf-native, but now when that was fixed it fails in do_compile. Build without opengl still works with works with my patch.
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#157453): https://lists.openembedded.org/g/openembedded-core/message/157453 Mute This Topic: https://lists.openembedded.org/mt/86232785/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
