Am 20.10.2021 um 10:05 schrieb Konrad Weihmann via lists.openembedded.org:
Jutst out of interest, why is this unnecessary?
That might be worth an explanation as part of the commit message, esp as
I think the assignments to 'configs' are still part of the class and now
being unused
This is a fix-up of a previous commit [1]. The config is passed to the
NpmEnvironment object and unnecessary at the function call.
I deprecated the configs argument because you could pass configs via
args for a single run function call or via NpmEnvironment class for
multi run function calls.
[1]
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/classes/npm.bbclass?id=fe87ab0a6a6f0c3d3fef4dd24a526dca3f9bde23
On 20.10.21 09:40, Stefan Herbrechtsmeier wrote:
From: Stefan Herbrechtsmeier <stefan.herbrechtsme...@weidmueller.com>
Signed-off-by: Stefan Herbrechtsmeier
<stefan.herbrechtsme...@weidmueller.com>
---
meta/classes/npm.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
index 547c531883..ba50fcac20 100644
--- a/meta/classes/npm.bbclass
+++ b/meta/classes/npm.bbclass
@@ -259,7 +259,7 @@ python npm_do_compile() {
# Pack and install the main package
tarball = npm_pack(env, d.getVar("NPM_PACKAGE"), tmpdir)
cmd = "npm install %s %s" % (shlex.quote(tarball),
d.getVar("EXTRA_OENPM"))
- env.run(cmd, args=args, configs=configs)
+ env.run(cmd, args=args)
}
npm_do_install() {
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#157254):
https://lists.openembedded.org/g/openembedded-core/message/157254
Mute This Topic: https://lists.openembedded.org/mt/86459810/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
