On Fri, 2021-09-10 at 17:36 +0100, Mike Crowe wrote: > On Monday 06 September 2021 at 17:37:14 +0100, Mike Crowe via > lists.openembedded.org wrote: > > On Friday 13 August 2021 at 12:05:09 +0100, Mike Crowe via > > lists.openembedded.org wrote: > > > When running the test suite on my Debian 11 box I see many occurrences > > > of: > > > > > > unknown fcntl argument 1032, assuming long argument. > > > > > > (for example from test-execl.sh.) > > > > > > It appears that this is F_GETPIPE_SZ and it takes no arguments. Let's > > > add it and the corresponding F_SETPIPE_SZ too to avoid the warning > > > messages. > > > > > > F_SETPIPE_SZ accepts an int argument, which strictly speaking isn't the > > > same as the long that the wrapper expects. However, this is also true > > > for F_DUPFD which seems to be working correctly on all the targets that > > > people care about. > > > > > > We need to define the command constants if the system headers don't > > > provide them to ensure that a binary built on an old system works > > > without the new commands works correctly only a newer one that tries to > > > use them. If the system values differ from the expected ones then such a > > > binary would also be incompatible, so fail the build in that case too. > > > > > > Signed-off-by: Mike Crowe <m...@mcrowe.com> > > > --- > > > Makefile.in | 1 + > > > ports/linux/guts/fcntl.c | 21 +++++++++++++++ > > > test/test-fcntl.c | 58 ++++++++++++++++++++++++++++++++++++++++ > > > test/test-fcntl.sh | 5 ++++ > > > 4 files changed, 85 insertions(+) > > > create mode 100644 test/test-fcntl.c > > > create mode 100755 test/test-fcntl.sh > > Hi Richard & Seebs, > > It looks like only part of this change landed as > 328452d74917ce9314c8c4afe2bd277473a4c076: > > > Makefile.in | 1 + > > ports/linux/guts/fcntl.c | 21 +++++++++++++++++++++ > > This means that the tests no longer pass: > > cc: error: test/test-fcntl.c: No such file or directory > > It looks like something similar happened with test-statx leading to > https://lists.openembedded.org/g/openembedded-core/message/154797 so I > wonder whether there's some sort of tooling fault somewhere?
Thanks, I've added those. I really don't know what happened. This all gets tricky as I have to fix up the email list mangling of your sender addresses, get these patches applied in a pseudo recipe as patches, run test builds, then get the patches over to the pseudo repo, push those then update the recipe. I guess the issue is we don't run the pseudo tests anywhere so we don't spot when they're missing. For most other issues I would see failures and fix things. Not sure if/where we'd want to run them but it is something to think about. We don't really have a good place for native tool testing. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#155932): https://lists.openembedded.org/g/openembedded-core/message/155932 Mute This Topic: https://lists.openembedded.org/mt/84860960/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
