> -----Original Message-----
> From: Andrey Zhizhikin <andre...@gmail.com>
> Sent: den 25 augusti 2021 12:20
> To: Peter Kjellerstedt <peter.kjellerst...@axis.com>
> Cc: Bruce Ashfield <bruce.ashfi...@gmail.com>; OE Core mailing list
> <openembedded-core@lists.openembedded.org>
> Subject: Re: [OE-core] [PATCH] lttng-modules: Make it build when
> CONFIG_TRACEPOINTS is not enabled again
>
> Hello Peter,
>
> On Wed, Aug 25, 2021 at 11:41 AM Peter Kjellerstedt
> <peter.kjellerst...@axis.com> wrote:
> >
> > Makefile-Do-not-fail-if-CONFIG_TRACEPOINTS-is-not-en.patch was updated
> > with the 2.13.0 update (commit 5dad15af), but unfortunately it no longer
> > did what it was intended to do.
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerst...@axis.com>
> > ---
> > ...fail-if-CONFIG_TRACEPOINTS-is-not-en.patch | 42 +++++++++++--------
> > 1 file changed, 25 insertions(+), 17 deletions(-)
> >
> > diff --git a/meta/recipes-kernel/lttng/lttng-modules/Makefile-Do-not-
> fail-if-CONFIG_TRACEPOINTS-is-not-en.patch b/meta/recipes-
> kernel/lttng/lttng-modules/Makefile-Do-not-fail-if-CONFIG_TRACEPOINTS-is-
> not-en.patch
>
> I guess the patch you've refreshed is not a correct one...
>
> There is another patch introduced by Bruce in the commit 18bf7b0
> ("lttng-modules: update devupstream to v2.13-rc "), namely
> 0001-src-Kbuild-change-missing-CONFIG_TRACEPOINTS-to-warn.patch
>
> It make sense to refresh rather that one instead of the Makefile one,
> and have it included in the SRC_URI (see discussion in
> https://lists.openembedded.org/g/openembedded-core/topic/84950303#154888).
>
> --
> Regards,
> Andrey.
Right, I had missed that there were two patches doing the same thing
(though neither actually solved the problem after the update to 2.13.0).
I will send an updated review unifying the patches and adding my solution
to disable building the module when CONFIG_TRACEPOINTS is not enabled.
//Peter
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#155295):
https://lists.openembedded.org/g/openembedded-core/message/155295
Mute This Topic: https://lists.openembedded.org/mt/85131925/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
