On Wed, 28 Jul 2021 13:49:17 -0700 Andre McCurdy <armccu...@gmail.com> wrote:
> If the caller only cares about yes/no then how about returning 1/0 > instead of a pointer? Other callers are actually using the response, because the pseudo_msg_t* returned from this is how, say, OP_STAT responds with the stat information it got from the server. It's just chroot, specifically, that wants to know that the client accepted-and-processed the chroot, but there's no meaningful additional information past that. I suppose in theory pseudo_client_op could be split into one function for ops with message returns and another for ops with only success/failure, or "just ignored", but it doesn't seem rewarding. In Go, I'd probably have done it as func (c *PseudoClient) Op(whatever goes here) (*Message, error) and this would just be returning (nil, nil) or (nil, some-meaningful-error) in the chroot case, but here we are in C with single return values. :) -s
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#154219): https://lists.openembedded.org/g/openembedded-core/message/154219 Mute This Topic: https://lists.openembedded.org/mt/84479678/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-