On Mon, Jul 26, 2021 at 12:27 PM Ruslan Babayev (fib) <f...@cisco.com> wrote: > > Hi Steve, > > Thanks for reviewing the patches. I understand the problem of merging this > patch as is. > But Dunfell currently has a host contamination issue on systems with zstd > installed as part of base OS resulting in broken cmake-native recipe. Can you > help bring this up to the attention of the steering committee?
Perhaps Richard can comment on this. You are asking for a feature change to dunfell that involves modifications in both openembedded-core and meta-openembedded. So both technical steering committees would need to agree that this is appropriate. > As for the other two patches in the series. Do they look OK? Do you see any > issues in merging them? Or would you like me to separated them from the cmake > patch? The other two patches don't have issues, so no need to re-submit! Steve > > Thanks, > Ruslan > > -----Original Message----- > From: Steve Sakoman <st...@sakoman.com> > Sent: Monday, July 26, 2021 8:05 AM > To: Ruslan Babayev (fib) <f...@cisco.com> > Cc: Patches and discussions about the oe-core layer > <openembedded-core@lists.openembedded.org>; Samuli Piippo > <samuli.pii...@gmail.com>; Samuli Piippo <samuli.pii...@qt.io>; Richard > Purdie <richard.pur...@linuxfoundation.org> > Subject: Re: [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd > support > > On Fri, Jul 23, 2021 at 11:45 AM Ruslan Babayev (fib) via > lists.openembedded.org <fib=cisco....@lists.openembedded.org> wrote: > > > > From: Samuli Piippo <samuli.pii...@gmail.com> > > > > CMake depends on having all formats supported and build issues can > > arise when zstd is not available: > > https://gitlab.kitware.com/cmake/cmake/-/issues/21552 > > > > Quote from a CMake dev: > > "As far as CMake's design is concerned, we have no optional formats. > > All should be supported. That's why we bundle sufficiently new > > versions of libarchive and libzstd. If a distro builds with an older > > libarchive that doesn't have zstd support, then that is not a proper > > packaging of CMake." > > > > Signed-off-by: Samuli Piippo <samuli.pii...@qt.io> > > Signed-off-by: Richard Purdie <richard.pur...@linuxfoundation.org> > > Signed-off-by: Ruslan Babayev <f...@cisco.com> > > --- > > meta/recipes-devtools/cmake/cmake-native_3.16.5.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb > > b/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb > > index b2952ee5f5..6034b654da 100644 > > --- a/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb > > +++ b/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb > > @@ -1,7 +1,7 @@ > > require cmake.inc > > inherit native > > > > -DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native > > curl-native ncurses-native" > > +DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native > > curl-native ncurses-native zstd-native" > > In hardknott/master the zstd recipe has been moved from meta-openembedded to > oe-core. This is not the case for dunfell, so this change will result in > failures for builds that do not include meta-openembedded. > > So this patch is not suitable for dunfell unless the community/steering > committee decide to also move the recipe in dunfell. > > Steve > > > > > SRC_URI += "file://OEToolchainConfig.cmake \ > > file://environment.d-cmake.sh \ > > -- > > 2.26.2.Cisco > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#154149): https://lists.openembedded.org/g/openembedded-core/message/154149 Mute This Topic: https://lists.openembedded.org/mt/84410822/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
