I suggest you use =+ instead of _prepend to maintain expansion order. I.e., if someone does:
inherit pypi SRC_URI = "http://some_url ${PYPI_SRC_URI}" However, any way you change it, you risk breaking someone’s use case, but I believe using =+ instead of += should be the least invasive change compared to the current version. //Peter From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Alexander Kanavin Sent: den 23 juni 2021 10:34 To: Konrad Weihmann <kweihm...@outlook.com> Cc: OE-core <openembedded-core@lists.openembedded.org> Subject: Re: [OE-core] [PATCH] pypi: set SRC_URI with =, not with += Right, I sent an updated patch. Alex On Wed, 23 Jun 2021 at 09:01, Konrad Weihmann <kweihm...@outlook.com<mailto:kweihm...@outlook.com>> wrote: That doesn't look completely right to me. You're absolutely right about devtool expecting the tarball in as the 1st item, but this patch here breaks existing recipes like SRC_URI += "file://some.patch" inherit pypi as the patch will now be dropped. I would suggest to go for SRC_URI_prepend = "${PYPI_SRC_URI} " which fixes the issue *and* doesn't break exisiting setups
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#153232): https://lists.openembedded.org/g/openembedded-core/message/153232 Mute This Topic: https://lists.openembedded.org/mt/83721889/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
