On Thu, May 13, 2021, at 4:08 PM, Richard Purdie wrote: > > The advice to anyone hitting this issue is to add in the correct branch > to the SRC_URI. It is simple and easy to do, can be in bbappends > or even changed via anonymous python and similar if necessary. We've already > found the issue with several core recipes, we simply updated them and most > users didn't notice. I would even likely take that kind of change into older > otherwise unmaintained branches and I think I did so in at least one case in > the past.
What I am uncertain about is: how quickly does that translate into us being able to remove the old branch? We're not the first project to do this and we won't be the last, so having a solution here will be good. Hmm actually I notice systemd upstream did the rename a while ago and they're not carrying a `master` branch. What's the difference between systemd and ostree here? Is it the use of `SRCREV`? Or no, in the systemd case is it because it's set to a tag? https://github.com/openembedded/openembedded-core/blob/2621dbbc1181808f18ca4ae79408d0d5b557670f/meta/recipes-core/systemd/systemd.inc#L18 ostree is also using tags, is the recipe just broken in not using tags? > I appreciate the tooling could do all kinds of magic things. I have a strong > preference for not adding magic into it, or over complicating it, it is > already > horrendously complicated and a nightmare to test. I appreciate nobody believes > me, I only do my best to maintain it. The code is here for anyone interested: > > http://git.yoctoproject.org/cgit.cgi/poky/tree/bitbake/lib/bb/fetch2/git.py Yeah, understood. > I'd also note you can add ;nobranch=1 to the urls or ;usehead=1. Those do > have side effects, I will not recommend them, or accept them for general use > in layers I maintain, they're considered developer options. I was reminded > recently that we have seen bugs the branch parameter has caught where a > revision was not where we thought it was so these do catch real world issues. Well I hope the result of this discussion is a recommended best practice at least. If recommending using a tag works, that seems good to me.
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#151739): https://lists.openembedded.org/g/openembedded-core/message/151739 Mute This Topic: https://lists.openembedded.org/mt/82782995/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
